CIDR Support in vertx-pg-client#1418
Conversation
| case 2: | ||
| // IPV4 | ||
| try { | ||
| address = Inet4Address.getByAddress(data); |
|
Addressed the previous comments. Please re-review it. @vietj |
|
can you squash your commits in a single one ? |
|
Sure ,doing it |
|
@vietj Hi sorry for delayed response, I have made the changes and squashed the commits into single commit. Kindly have a look at it |
|
Hi @vietj , any review comments on the PR? |
vietj
left a comment
vietj
left a comment
There was a problem hiding this comment.
I cannot see any tests with a real database and the CIDR type, we need to have at least a test that read / write CIDR objects to a test container postgresql instance. Look at how other specific types are tested.
|
@vietj I have added test cases dependent on a real database. I have tested them with pg embedded version 12 as previous versions didn't have CIDR support. Please review and provide input. |
|
great feature thanks @AyanKoche |
3 participants
Motivation: CIDR Data type support in vertx-pg-client
Explain here the context, and why you're making that change, what is the problem you're trying to solve.
There are several data types supported by vertx-pg-client but CIDR was missing implementation. As the project I am working on requires that support, contributing it is the better way.
Changes:
Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines